Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Note why Handle methods in win won't panic #8

Closed
KodrAus opened this issue Jul 24, 2017 · 1 comment
Closed

Note why Handle methods in win won't panic #8

KodrAus opened this issue Jul 24, 2017 · 1 comment

Comments

@KodrAus
Copy link
Contributor

KodrAus commented Jul 24, 2017

Relevant API Guidelines:

The win implementation of Handle calls unwrap in the following methods:

  • Drop::drop
  • AsRawFd::as_raw_fd
  • IntoRawFd::into_raw_fd
  • as_file
  • as_file_mut

These calls should either have a comment inline documenting why they can't fail, or a Panics section should be added to the docs documenting when they will fail.
@KodrAus KodrAus mentioned this issue Jul 24, 2017
Closed
14 tasks
@yandexx
Copy link
Contributor

yandexx commented Jul 31, 2017

I'll have a look into this.

yandexx added a commit to yandexx/same-file that referenced this issue Aug 2, 2017
@yandexx
Note why Handle methods in win won't panic
764b392 
Fixes BurntSushi#8
This was referenced Aug 2, 2017
Merged
Closed
yandexx added a commit to yandexx/same-file that referenced this issue Aug 3, 2017
@yandexx @v-zubarev
Note why Handle methods in win and unix won't panic
4cf4b95 
Fixes BurntSushi#7
Fixes BurntSushi#8
BurntSushi pushed a commit that referenced this issue Aug 3, 2017
@yandexx @BurntSushi
Note why Handle methods in win and unix won't panic
8c09246 
Fixes #7
Fixes #8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yandexx @KodrAus