Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

break lexBool loop on ',' to allow decoding []bool #166

Closed
wants to merge 1 commit into from
Closed

break lexBool loop on ',' to allow decoding []bool #166

wants to merge 1 commit into from

Conversation

maclav3
Copy link

@maclav3 maclav3 commented Mar 21, 2017

lexBool would break on decoding key = [true, false], because the loop would go up to true, and then miss both cases.

lexBool would break on decoding `key = [true, false]`, because the loop would go up to `true,` and then miss both cases.
@cespare
Copy link
Collaborator

cespare commented Mar 28, 2017

@maclav3 thanks very much for bringing this bug to our attention.

There were some other cases besides comma: for instance, in your example, the ] that comes after false would become part of that token. The inline table terminator, }, is another exception.

I ended up fixing this using a different workaround in b26d9c3.

@cespare cespare closed this Mar 28, 2017
@maclav3 maclav3 deleted the patch-1 branch March 29, 2017 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants