Add lexer/parser changes for inline table support #71
Conversation
ttacon
changed the title
|
👍 this would be very nice to see merged. |
| @@ -424,6 +424,44 @@ name = "Rice" | |||
|
|
|||
| } | |||
|
|
|||
| func TestDecodeInlineTable(t *testing.T) { | |||
| inlineToml := ` | |||
There was a problem hiding this comment.
inlineTOML, but just input would be a fine name.
|
This would be great to have. @BurntSushi got any time to review this? |
|
@BurntSushi Is there something holding this up? 0.4.0 has been out forever, can we support it yet? :( |
|
I needed to use this PR right away (thanks for your work, @ttacon) so I made a fork which merges it into the current upstream (BurntSushi) master. Feel free to use it if you also need a stopgap solution until it makes it into upstream! https://github.com/zhaytee/toml |
|
We also forked and applied this fix on top. Works like a charm. Gotta love open source. |
|
This is one of my favorite Go repos, but it looks like @BurntSushi has transitioned fully to Rust given Github activity. @cespare seems active, but not here. Let's be honest about this pull request: Opened in 2015, not merged yet... Cespare gave it a brief look... 7 months ago. And it's not just any old pull request, this is part of the roadmap for 0.4.0 support. Maybe it's time to start the conversation about adding collaborators to this repo or permanent forking if neither have time for it? Hopefully they'll say something in response to something as dire as the word "fork" :) |
|
@aarondl I haven't "transitioned fully to Rust." I still use Go every single day. My public Github activity is not a complete picture of my activity. I just haven't had the time to get back to this project. (Some of my Rust projects have old PRs too, although none quite this bad!) I defer to @cespare on this, but I do think we should get inline table support to be spec conforming. (I'm not necessarily opposed to a fork, but I would like to hear from @cespare. In particular, I would much prefer a transfer of ownership/maintenance over a fork.) |
|
Sounds fine to me. The end goal is simply to have this/that be a first class up-to-spec TOML implementation as it used to be. Sorry for the Rust comment, I did hint that I was trying to be inflammatory to evoke a response though (and it worked!). Many thanks for having created this in the first place and your work on it so far. |
|
Oh, I'd been waiting for my review comments to be addressed. I'll re-review, merge, and clean this up shortly. |
|
I looked at this for a few minutes and I notice that, for one, this allows newlines within inline tables which is specifically disallowed by the spec. I've set aside some time for working on open-source projects while I'm on vacation next week, so I'll close out this issue then. |
|
I merged this, reworked the tests, and changed to to disallow newlines within inline tables. Thanks @ttacon for the contribution. |
These are the changes I've made so far in reference to issue #70 .