Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document why unwraps won't fail #42

Closed
3 tasks
KodrAus opened this issue Jun 14, 2017 · 1 comment
Closed
3 tasks

Document why unwraps won't fail #42

KodrAus opened this issue Jun 14, 2017 · 1 comment

Comments

@KodrAus
Copy link
Contributor

KodrAus commented Jun 14, 2017

We should add some inline comments to the few calls to unwrap so it's clear to readers why it's safe to call unwrap in those places. All unwraps:

  • <Iter as Iterator>::next
  • Iter::get_deferred_dir
  • Iter::push

We might also want to change these to expects with a simple message that the panic is a bug in walkdir.
@KodrAus KodrAus mentioned this issue Jun 14, 2017
Closed
22 tasks
@shssoichiro
Copy link
Contributor

I'd like to work on this issue.

@shssoichiro shssoichiro mentioned this issue Jun 28, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@shssoichiro @KodrAus