Skip to content

/walkdir

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document why unwraps won't fail #42

Closed
KodrAus opened this Issue Jun 14, 2017 · 1 comment

Comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@KodrAus @shssoichiro
@KodrAus
Copy link
Contributor

KodrAus commented Jun 14, 2017

We should add some inline comments to the few calls to unwrap so it's clear to readers why it's safe to call unwrap in those places. All unwraps:

  • <Iter as Iterator>::next
  • Iter::get_deferred_dir
  • Iter::push

We might also want to change these to expects with a simple message that the panic is a bug in walkdir.

@KodrAus KodrAus referenced this issue Jun 14, 2017

Closed

Tracking issue for libz blitz evaluation of walkdir #47

22 of 22 tasks complete
@shssoichiro

This comment has been minimized.

Sign in to view
Copy link
Contributor

shssoichiro commented Jun 28, 2017

I'd like to work on this issue.

@shssoichiro shssoichiro referenced this issue Jun 28, 2017

Merged

Document why unwraps won't fail #63

@BurntSushi BurntSushi closed this in #63 Jul 21, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.