Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create PolymerTS compatible annotations #60

Closed
Buslowicz opened this issue Jan 11, 2017 · 4 comments
Closed

Create PolymerTS compatible annotations #60

Buslowicz opened this issue Jan 11, 2017 · 4 comments
Assignees

Comments

@Buslowicz
Copy link
Owner

Create set of annotations to map PolymerTS decorators. Properties not annoted as @property should not be registered within properties object.

@Buslowicz Buslowicz added this to the Beta 2 milestone Jan 11, 2017
@Buslowicz Buslowicz self-assigned this Jan 11, 2017
@tpluscode
Copy link
Contributor

Would this be the default or opt-in?

@Buslowicz
Copy link
Owner Author

It will be imported just like now, but instead of twc/annotations/polymer it will be something like twc/annotations/polymerts.

@tpluscode
Copy link
Contributor

tpluscode commented Jan 11, 2017

Properties not annoted as @Property should not be registered within properties object.

I'm concerned about this sentence. What would be the output of:

import { property } from 'twc/annotations/polymerts';
import { notify } from 'twc/annotations/polymer';

export class MyElement {
  
  @property({ notify: true });
  polymerTsProp: Object;

  @notify
  oldSchoolProp: Number;
}

Would the oldSchoolProp appear in the output or not?

@Buslowicz
Copy link
Owner Author

All the decorators will be fetched from either polymer or polymerts annotations set. Fetching polymerts will automatically disable property auto registration so it works pretty much like PolymerTS. It will not, however, change how current twc annotations work.

@Buslowicz Buslowicz removed this from the Beta 2 milestone Apr 4, 2017
Buslowicz pushed a commit that referenced this issue Jul 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants