Implement translations in the views #205
Conversation
* add 404 page translations * English and Dutch translations for confirm-profile.ejs
|
Fantastic work! Will look through it now |
| "/healthcondition/": "/healthcondition/", | ||
| "Your age": "Your age", | ||
| "Choose your age": "Choose your age", | ||
| "Biological gender": "Biological gender/Sex", |
There was a problem hiding this comment.
Should probably not use gender at all?
There was a problem hiding this comment.
I don't have a strong opinion on this other than having "biological gender" there making it easier to understand "sex" in context.
app/locales/en.json
Outdated
| "Statistics": "Statistics", | ||
| "Download the dataset as CSV": "Download the dataset as CSV", | ||
| "COVID-19 infected": "COVID-19 infected", | ||
| "In total <%= numberWithSpaces(totalInfectedPeopleWithSymptoms) %> people have reported that they have tested positive for COVID-19 and experience symptoms.": "In total <%= numberWithSpaces(totalInfectedPeopleWithSymptoms) %> people have reported that they have tested positive for COVID-19 and experience symptoms.", |
There was a problem hiding this comment.
Did you check if using <%= numberWithSpaces(totalInfectedPeopleWithSymptoms) %>works? Should maybe rather be split up.
There was a problem hiding this comment.
Yeah I overlooked this. It's fixed for one instance but I'll (or someone else) go over the others and fix them.
app/locales/en.json
Outdated
| "Added to form": "Added to form", | ||
| "Headache": "Headache", | ||
| "Sore throat": "Sore throat", | ||
| "Loss of sense of taste": "Loss of sense of taste", |
There was a problem hiding this comment.
There are some dupes, don't know if that matters or not.
There was a problem hiding this comment.
That's what happens in merge-hell :( We can remove dupes
app/locales/en.json
Outdated
| "Loss of sense of smell": "Loss of sense of smell", | ||
| "Mucus cough": "Mucus cough", | ||
| "Stuffy or runny nose": "Stuffy or runny nose", | ||
| "Statistics": "Statistieken", |
There was a problem hiding this comment.
Line 135-172 contains NL translations, should be removed
|
Not all translations made it into the dutch translation file, should be checked. |
| <h3 class="stat-heading">Nøkkeltall</h3> | ||
| <div>Av alle som har rapportert, har:</div> | ||
| <h3 class="stat-heading"><%= __('Key figures') %></h3> | ||
| <div><%= __('Everyone who has submitted a report, also has:') %></div> |
|
👍 as you suggested, we should probably just merge this asap. Me and @michaelmcmillan can test the Norwegian version afterwords, and see if we find any errors. |
This is a monster PR, sorry about that :) Should have all views translated and is rebased on latest master to should merge cleanly. Best to get that done asap to prevent conflicts with other work-in-progress!