Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helio Target #5

Merged
merged 11 commits into from
Mar 4, 2018
Merged

Helio Target #5

merged 11 commits into from
Mar 4, 2018

Conversation

apocolipse
Copy link

Helio Spring target

@kidBrazil
Copy link
Member

Looks good to me, lets wait for @rs2k for a final word.

Copy link

@rs2k rs2k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

#include "drivers/accgyro/accgyro_mpu.h"


volatile int dmaSpiGyroDataReady = 0;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not used, it's kind of a place holder. Maybe we should remove it for now?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will remove


static inline void dmaSpiCsHi(void)
{
gpio_write_pin(DMA_SPI_NSS_PORT, DMA_SPI_NSS_PIN, 1);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these functions probably belong in the gpio driver files, but the bf hal is being used there, so maybe we need a new "fast_gpio" driver

@@ -160,6 +165,35 @@ static void gyroInitSensorFilters(gyroSensor_t *gyroSensor);

PG_REGISTER_WITH_RESET_TEMPLATE(gyroConfig_t, gyroConfig, PG_GYRO_CONFIG, 1);

#ifdef USE_GYRO_IMUF9001
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dang maros!

static void cliImufUpdate(char *cmdline)
{
UNUSED(cmdline);
cliPrint("I muff, you muff, we all muff for IMU-F!");
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Best. Line. Ever.


#define IMUF_BIT_I2C_IF_DIS (1 << 4)
#ifndef DEBUG
#define USE_QUAD_MIXER_ONLY
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure why this doesn't work in debug mode. :(

@@ -89,7 +89,7 @@ extern "C" {
[TASK_ATTITUDE] = {
.taskName = "ATTITUDE",
.taskFunc = imuUpdateAttitude,
.desiredPeriod = TASK_PERIOD_HZ(100),
.desiredPeriod = TASK_PERIOD_HZ(1000),
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:)

#include "sensors/boardalignment.h"
volatile int isImufCalibrating = 0;

void crcConfig(void)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only used on F3's and F7's. Left it as a place holder for them.

}

crcConfig();
//making pancakes
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what about sausages?

"MPU6000", "MPU6500", "MPU9250", "ICM20601", "ICM20602", "ICM20608G", "ICM20649", "ICM20689",
"BMI160", "FAKE"
"MPU6000", "MPU6500", "MPU9250", "ICM20601", "ICM20602", "ICM20608", "ICM20649", "ICM20689",
"BMI160", "ACC_IMUF9001", "FAKE"
};
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be ICM20608G

@apocolipse apocolipse force-pushed the helio_target branch 2 times, most recently from 3322357 to 26a7399 Compare February 26, 2018 04:55
apocolipse pushed a commit that referenced this pull request Feb 28, 2018
Reverted identifier so it can still work with BF Configurator
@apocolipse apocolipse merged commit fc4a490 into master Mar 4, 2018
@orneryd orneryd deleted the helio_target branch March 12, 2018 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants