-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Helio Target #5
Helio Target #5
Conversation
Looks good to me, lets wait for @rs2k for a final word. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
#include "drivers/accgyro/accgyro_mpu.h" | ||
|
||
|
||
volatile int dmaSpiGyroDataReady = 0; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is not used, it's kind of a place holder. Maybe we should remove it for now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will remove
|
||
static inline void dmaSpiCsHi(void) | ||
{ | ||
gpio_write_pin(DMA_SPI_NSS_PORT, DMA_SPI_NSS_PIN, 1); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these functions probably belong in the gpio driver files, but the bf hal is being used there, so maybe we need a new "fast_gpio" driver
@@ -160,6 +165,35 @@ static void gyroInitSensorFilters(gyroSensor_t *gyroSensor); | |||
|
|||
PG_REGISTER_WITH_RESET_TEMPLATE(gyroConfig_t, gyroConfig, PG_GYRO_CONFIG, 1); | |||
|
|||
#ifdef USE_GYRO_IMUF9001 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dang maros!
src/main/interface/cli.c
Outdated
static void cliImufUpdate(char *cmdline) | ||
{ | ||
UNUSED(cmdline); | ||
cliPrint("I muff, you muff, we all muff for IMU-F!"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Best. Line. Ever.
src/main/target/HELIOSPRING/target.h
Outdated
|
||
#define IMUF_BIT_I2C_IF_DIS (1 << 4) | ||
#ifndef DEBUG | ||
#define USE_QUAD_MIXER_ONLY |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure why this doesn't work in debug mode. :(
@@ -89,7 +89,7 @@ extern "C" { | |||
[TASK_ATTITUDE] = { | |||
.taskName = "ATTITUDE", | |||
.taskFunc = imuUpdateAttitude, | |||
.desiredPeriod = TASK_PERIOD_HZ(100), | |||
.desiredPeriod = TASK_PERIOD_HZ(1000), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:)
#include "sensors/boardalignment.h" | ||
volatile int isImufCalibrating = 0; | ||
|
||
void crcConfig(void) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
only used on F3's and F7's. Left it as a place holder for them.
} | ||
|
||
crcConfig(); | ||
//making pancakes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what about sausages?
src/main/interface/settings.c
Outdated
"MPU6000", "MPU6500", "MPU9250", "ICM20601", "ICM20602", "ICM20608G", "ICM20649", "ICM20689", | ||
"BMI160", "FAKE" | ||
"MPU6000", "MPU6500", "MPU9250", "ICM20601", "ICM20602", "ICM20608", "ICM20649", "ICM20689", | ||
"BMI160", "ACC_IMUF9001", "FAKE" | ||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be ICM20608G
3322357
to
26a7399
Compare
Reverted identifier so it can still work with BF Configurator
Helio Spring target