PaPaYoU - Introducing LUA and OSD Updates to utilize the new Filter parameters #51
Conversation
Replace kd_filter variable name
kidBrazil
changed the title
|
hey @papayou66 what is the status of your testing with this so far? |
papayou66
changed the title
|
@papayou66 can you please take a look at Travis - seems there is an issue https://travis-ci.org/ButterFlight/butterflight/jobs/354760664 |
|
Travis is my friend today |
| @@ -70,9 +70,9 @@ typedef enum { | |||
| } filterType_e; | |||
|
|
|||
| typedef enum { | |||
| KD_FILTER_CLASSIC = 0, | |||
There was a problem hiding this comment.
Hate to do this to ya PaPaYou but I think we should revert this change and keep them as KD_FILTER_XXXX - just so the code clarity is improved.
SP / CLASSIC / NOSP are fine for people familiar with the genesis of these features but for anyone else that comes in on this code it might be confusing. The KD_FILTER add some clarity by making it immeditaly obvious that its dealing with D term filters.
src/main/flight/pid.c
Outdated
| @@ -108,7 +108,7 @@ void resetPidProfile(pidProfile_t *pidProfile) | |||
| .dterm_notch_hz = 260, | |||
| .dterm_notch_cutoff = 160, | |||
| .dterm_filter_type = FILTER_PT1, | |||
| .dterm_filter_style = KD_FILTER_CLASSIC, | |||
| .dterm_filter_style = CLASSIC, | |||
src/main/flight/pid.c
Outdated
| float delta = 0.0f; | ||
| float iDT = 1.0f/deltaT; //divide once | ||
|
|
||
| switch (pidProfile->dterm_filter_style) { | ||
| case KD_FILTER_CLASSIC: | ||
| case CLASSIC: |
There was a problem hiding this comment.
Revert cases to KD_FILTER_XXXX variant
| sbufWriteU16(dst, gyroConfig()->gyro_filter_q); | ||
| sbufWriteU16(dst, gyroConfig()->gyro_filter_r); | ||
| sbufWriteU16(dst, gyroConfig()->gyro_filter_p); | ||
| sbufWriteU8(dst, gyroConfig()->gyro_stage2_filter_type); |
There was a problem hiding this comment.
Do we not need gyro_stage2_filter_type anymore?
| break; | ||
| #endif | ||
|
|
||
| #ifdef USE_GYRO_IMUF9001 |
There was a problem hiding this comment.
Something whack going on with the TABS on this area - could we please get that harmonized to line up with the rest?
src/main/interface/settings.c
Outdated
| @@ -250,7 +250,7 @@ static const char * const lookupTableLowpassType[] = { | |||
| }; | |||
|
|
|||
| static const char * const lookupTableKdStyle[] = { | |||
| "KD_FILTER_CLASSIC", "KD_FILTER_SP", "KD_FILTER_NOSP" | |||
src/main/target/HELIOSPRING/config.c
Outdated
| @@ -80,12 +80,11 @@ void targetConfiguration(void) { | |||
| pidProfile->itermAcceleratorGain = 5000; | |||
| // should't need to set these since they don't get init in gyro.c with USE_GYRO_IMUF | |||
There was a problem hiding this comment.
If these are really no longer needed we should just remove them entirely instead of leaving comments IMO
change typo about KD_FILTER CLASSIC SP and NOSP
|
Switch to a new branch to avoid merge conflict |
Lua stuff
add imuf