Skip to content

Commit

Permalink
Fixed logic glitch where ConfigFactory.pkgType must must be evaluated…
Browse files Browse the repository at this point in the history
… with 0 vs None as distinct conditions. (i.e. the package type "enum" for "DATA" is 0, setting up this gotcha)
  • Loading branch information
BuvinJ committed Feb 8, 2021
1 parent 72073fe commit 5fc0203
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion distbuilder/master.py
Original file line number Diff line number Diff line change
Expand Up @@ -293,7 +293,7 @@ def __ifwPkgId( self ):
return prod

def __ifwPkgType( self ):
if self.pkgType : return self.pkgType
if self.pkgType is not None: return self.pkgType
if self.__pkgPyInstConfig : return QtIfwPackage.Type.PY_INSTALLER
if self.pkgSrcExePath is None:
return ( QtIfwPackage.Type.DATA if self.binaryName is None else
Expand Down

0 comments on commit 5fc0203

Please sign in to comment.