Docs and comments updates.

BuvinJT · Jan 6, 2021 · a2e5bde · a2e5bde
1 parent 8ca4c36
commit a2e5bde
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 0 deletions.
diff --git a/distbuilder/qt_installer.py b/distbuilder/qt_installer.py
@@ -5155,6 +5155,18 @@ def RemoveDir( event, dirPath, isElevated=True ): # TODO: Test in NIX/MAC
             isElevated=isElevated )
 
     # TODO: Test in NIX/MAC 
+    #
+    # TODO: Fix a glitch on Windows with employing isHidden.  This is a problem
+    # throughout the library - the PS -WindowStlye Hidden is not respected
+    # by all applications - including our basic demos with PyInstaller / Tk!
+    # (not sure which is to blame - but it's probably Tk?)
+    #
+    # TODO: Fix a glitch on Windows with setting isSynchronous to False. 
+    # In the context of running one of our uninstallers as a sub process 
+    # from one of our installers, an asynchronous program launch will still
+    # produce a blocking condition because the installer launches using
+    # a PowerShell StartProcess -Wait which sees the asynch program as a child
+    # process it must wait for.   
     @staticmethod
     def RunProgram( event, path, arguments=None, isAutoQuote=True,  
                     isHidden=False, isSynchronous=True, isElevated=True,

diff --git a/docs/ConfigClasses.md b/docs/ConfigClasses.md
@@ -793,6 +793,7 @@ Event constants for convenience methods.
 
     RunProgram( event, path, arguments=None, isAutoQuote=True,  
                 isHidden=False, isSynchronous=True, isElevated=True, 
+                runConditionFileName=None, isRunConditionNegated=False,
                 isAutoBitContext=True )
 
 On Windows, set `isAutoBitContext=False` if you need to execute a 64 bit
@@ -903,6 +904,7 @@ use of SysWow64 nodes.
 
     RunProgramScript( path, arguments=None, isAutoQuote=True, 
     				  isHidden=False, isSynchronous=True,
+    				  runConditionFileName=None, isRunConditionNegated=False,
     				  isAutoBitContext=True, 
     				  replacements=None )
 

diff --git a/examples/hello_qtifw_ops/cascading_scripts.py b/examples/hello_qtifw_ops/cascading_scripts.py
@@ -138,6 +138,12 @@ def launchAppIfFound( event, exePath, appFoundFileName ):
             APP_FOUND_FILENAME = "ConveniencesAppInstalled"
             EXE_PATH = joinPath( QT_IFW_APPS_X86_DIR, COMPANY_NAME, APP_NAME, 
                                  EXE_NAME )
+            # This demos conditionally launching an app on BOTH install and 
+            # uninstall.  Since operations are executed in REVERSE order during 
+            # uninstallation, for cascading scripts to flow into each other 
+            # correctly, we need to account for that nuance.  As such, this
+            # example shows a setAppFoundFileOp call in the list both before
+            # and after the launchAppIfFound.    
             pkg.pkgScript.externalOps += [
                 setAppFoundFileOp( QtIfwExternalOp.ON_INSTALL,
                                    APP_NAME, IS_32BIT_REG, APP_FOUND_FILENAME ),