Skip to content

Commit

Permalink
fix: Fix error on meltano config meltano set ... (meltano#6819)
Browse files Browse the repository at this point in the history
  • Loading branch information
WillDaSilva committed Sep 30, 2022
1 parent 7686939 commit 1b71f7a
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 1 deletion.
1 change: 0 additions & 1 deletion src/meltano/cli/interactive/config.py
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,6 @@ def __init__(self, ctx, store, extras=False, max_width=None):
self.project = self.ctx.obj["project"]
self.settings = self.ctx.obj["settings"]
self.session = self.ctx.obj["session"]
self.plugin = self.ctx.obj["settings"].plugin
self.tracker = self.ctx.obj["tracker"]
self.environment_service = EnvironmentService(self.project)
self.max_width = max_width or 75 # noqa: WPS432
Expand Down
16 changes: 16 additions & 0 deletions tests/meltano/cli/test_config.py
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,22 @@ def test_config_meltano(
assert json_config["database_uri"] == engine_uri
assert json_config["cli"]["log_level"] == "info"

def test_config_meltano_set(
self, project: Project, cli_runner, project_plugins_service
):
with mock.patch(
"meltano.cli.config.ProjectPluginsService",
return_value=project_plugins_service,
):
result = cli_runner.invoke(
cli, ["config", "meltano", "set", "cli.log_config", "log_config.yml"]
)
assert_cli_runner(result)
assert (
"Meltano setting 'cli.log_config' was set in `meltano.yml`: 'log_config.yml'"
in result.stdout
)

def test_config_test(
self, project: Project, cli_runner, tap, project_plugins_service
):
Expand Down

0 comments on commit 1b71f7a

Please sign in to comment.