fix: Regression in meltano remove with error stating the plugin is …

…missing the `settings_with_extras` attribute (meltano#6694)
BuzzCutNorman · Sep 1, 2022 · ba088e9 · ba088e9
1 parent c22ffa7
commit ba088e9
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 5 deletions.
diff --git a/.gitignore b/.gitignore
@@ -32,6 +32,7 @@ api/parser
 *.ntvs*
 *.njsproj
 *.sln
+.sourcery.yaml
 
 # Byte-compiled / optimized / DLL files
 __pycache__/

diff --git a/docs/example-library/meltano-objects/ending-meltano.yml b/docs/example-library/meltano-objects/ending-meltano.yml
@@ -7,10 +7,6 @@ environments:
 - name: qa
 - name: prod
 plugins:
-  extractors:
-  - name: tap-gitlab
-    variant: meltanolabs
-    pip_url: git+https://github.com/MeltanoLabs/tap-gitlab.git
   loaders:
   - name: target-jsonl
     variant: andyh1203

diff --git a/docs/example-library/meltano-objects/index.md b/docs/example-library/meltano-objects/index.md
@@ -31,3 +31,9 @@ meltano job add gitlab_to_jsonl --tasks '["tap-gitlab target-jsonl"]'
 ```shell
 meltano schedule add run_gitlab --job gitlab_to_jsonl --interval "@daily"
 ```
+
+## Remove a plugin
+
+```shell
+meltano remove extractor tap-gitlab
+```
diff --git a/src/meltano/core/plugin/settings_service.py b/src/meltano/core/plugin/settings_service.py
@@ -62,7 +62,7 @@ def __init__(
 
         environment_env = {}
         if self.project.active_environment:
-            with self.feature_flag(
+            with project_settings_service.feature_flag(
                 FeatureFlags.STRICT_ENV_VAR_MODE, raise_error=False
             ) as strict_env_var_mode:
                 environment_env = {