fix: Terminal output from plugin installation is now safely decoded (m…

…eltano#8436)
BuzzCutNorman · Mar 6, 2024 · c4b7eeb · c4b7eeb
1 parent 763994e
commit c4b7eeb
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/src/meltano/core/venv_service.py b/src/meltano/core/venv_service.py
@@ -325,6 +325,7 @@ async def create(self) -> Process:
         async def extract_stderr(proc: Process):
             return (await t.cast(asyncio.StreamReader, proc.stdout).read()).decode(
                 "unicode_escape",
+                errors="replace",
             )
 
         try:
@@ -441,7 +442,7 @@ async def extract_stderr(proc: Process) -> str | None:  # pragma: no cover
             if not proc.stdout:
                 return None
 
-            return (await proc.stdout.read()).decode("unicode_escape")
+            return (await proc.stdout.read()).decode("unicode_escape", errors="replace")
 
         try:
             return await exec_async(