Fix my regression (b7d25b0) in sequence loop end/play end handling. #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ensonic
reviewed
Feb 8, 2024
src/lib/core/sequence.c
Outdated
| * @length: the new value requested for length | ||
| * | ||
| * Handles making sure that loop-end doesn't extend past song length, and also | ||
| * makes sure that loop-end is set to the song length, then the loop-end is |
There was a problem hiding this comment.
sure that if loop-end is set ...
ensonic
reviewed
Feb 8, 2024
src/lib/core/sequence.c
Outdated
| */ | ||
| static void | ||
| bt_sequence_post_length_change (const BtSequence * const self, | ||
| guint old_length) |
There was a problem hiding this comment.
gulong old_length
to avoid truncating
ensonic
reviewed
Feb 8, 2024
src/lib/core/sequence.c
Outdated
| bt_sequence_resize_data_length (const BtSequence * const self, const gulong length) | ||
| { | ||
| const gulong tracks = self->priv->tracks; | ||
|
|
||
| const gulong old_length = self->priv->len_patterns; | ||
|
|
||
| // try to shrink the pattern up to the row having the final non-empty pattern cell | ||
| /* Try to shrink the pattern up to the row having the final non-empty pattern |
ensonic
reviewed
Feb 8, 2024
Removed "len-patterns" property setter. This property may not agree to set itself to a value that would cause pattern truncation, so the value supplied to g_object_set may not match g_object_get. Not only does this confuse the automated tests (check_readwrite_long_param) but sequence data size management should ideally be a hidden implementation detail.
dlbeswick
force-pushed
the
bug/136_sequence_regression
branch
from
48c7c03
to
bc9d420
Compare
|
Nits are good too, fixed those. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also removed "len-patterns" property setter. This property may not agree to set itself to a value that would cause pattern truncation, so the value supplied to g_object_set may not match g_object_get. Not only does this confuse the automated tests (check_readwrite_long_param) but sequence data size management should ideally be a hidden implementation detail.
Fixes #136.