Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve grammar for single periodic second/minute/hour #1

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

Bwooce
Copy link
Owner

@Bwooce Bwooce commented Aug 14, 2023

Trigger every 1 hours -> Trigger every hour
Trigger every 1 minutes -> Trigger every minute
Trigger every 1 seconds -> Trigger every second

(and combinations thereof)

Proposed change

Grammar annoyed me for single periodic triggers, so here's a small fix

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Automation like so, redundant intervals just to demo in one go (/1 second would be enough...):

alias: Trigger every second of every minute of every hour 
description: ""
trigger:
  - minutes: /1
    platform: time_pattern
    hours: /1
    seconds: /1
condition:
action:
mode: single

Additional information

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

Trigger every 1 hours -> Trigger every hour
Trigger every 1 minutes -> Trigger every minute
Trigger every 1 seconds -> Trigger every second

(and combinations thereof)
Conditions need the boolean and the number. Oops.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant