Lint fixes

By-Nordenfelt-AB · Dec 5, 2018 · ab3835c · ab3835c
1 parent 4a2deec
commit ab3835c
Show file tree

Hide file tree

Showing 5 changed files with 19 additions and 15 deletions.
diff --git a/example/index.js b/example/index.js
@@ -1,3 +1,4 @@
+/* istanbul ignore file */
 const Lulo = require('lulo');
 
 const lulo = Lulo({ logEvents: true, logResponse: true })

diff --git a/src/lib/cfn-response.js b/src/lib/cfn-response.js
@@ -6,7 +6,7 @@
  This file is distributed on an 'AS IS' BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, express or implied.
  See the License for the specific language governing permissions and limitations under the License.
  */
-
+/* istanbul ignore file */
 const log   = require('log4njs');
 const https = require('https');
 const url   = require('url');
@@ -40,7 +40,7 @@ module.exports = (error, response, event, context, logResponse, callback) => {
         RequestId: event.RequestId,
         LogicalResourceId: event.LogicalResourceId,
         Data: responseData,
-        NoEcho: event.ResourceProperties._NoEcho ? true : false
+        NoEcho: !!event.ResourceProperties._NoEcho
     });
 
     const parsedUrl = url.parse(event.ResponseURL);

diff --git a/tests/unit/index-unit-test.js b/tests/unit/index-unit-test.js
@@ -1,19 +1,17 @@
-'use strict';
-
-const expect = require('chai').expect;
+const expect  = require('chai').expect;
 const mockery = require('mockery');
-const sinon = require('sinon');
+const sinon   = require('sinon');
 
 describe('Index unit tests', () => {
     let subject;
     let event;
-    const responseStub = sinon.stub();
-    const validateStub = sinon.stub();
-    const createStub = sinon.stub();
-    const updateStub = sinon.stub();
-    const deleteStub = sinon.stub();
-    const logStub = sinon.stub();
-    const logEventStub = sinon.stub();
+    const responseStub  = sinon.stub();
+    const validateStub  = sinon.stub();
+    const createStub    = sinon.stub();
+    const updateStub    = sinon.stub();
+    const deleteStub    = sinon.stub();
+    const logStub       = sinon.stub();
+    const logEventStub  = sinon.stub();
     const normalizeStub = sinon.stub();
 
     before(() => {
@@ -86,6 +84,7 @@ describe('Index unit tests', () => {
         it('should fail on duplicate', (done) => {
             expect(registerDuplicate).to.throw(/Trying to register same plugin name twice/);
             done();
+
             function registerDuplicate() {
                 subject()
                     .register('testPlugin', {})

diff --git a/tests/unit/lib/log-event-unit-test.js b/tests/unit/lib/log-event-unit-test.js
@@ -15,7 +15,9 @@ describe('Logger unit tests', () => {
 
         const logMock = {
             info: infoStub,
-            options: function () { return logMock; }
+            options: function () {
+                return logMock;
+            }
         };
 
         mockery.registerMock('log4njs', logMock);

diff --git a/tests/unit/lib/normalize-unit-test.js b/tests/unit/lib/normalize-unit-test.js
@@ -15,7 +15,9 @@ describe('Normalize unit tests', () => {
 
         const logMock = {
             warn: warnStub,
-            options: function () { return logMock; }
+            options: function () {
+                return logMock;
+            }
         };
         mockery.registerMock('log4njs', logMock);
         subject = require('../../../src/lib/normalize');