feat: StorageCnchMergeTree properly supports skipping indices #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Clark0 I temporary disable adaptive index granularity tests, seem it's not working with secondary indexes |
canhld94
changed the title
canhld94
changed the title
Clark0
reviewed
Mar 10, 2023
| DROP TABLE IF EXISTS indexed_table; | ||
| CREATE TABLE indexed_table | ||
| ( `tm` DateTime, | ||
| `log_message` String, | ||
| INDEX log_message log_message TYPE tokenbf_v1(4096, 2, 0) GRANULARITY 1 | ||
| )ENGINE = CnchMergeTree ORDER BY (tm) SETTINGS index_granularity_bytes = 50; --, min_index_granularity_bytes = 40; | ||
| ) ENGINE = CnchMergeTree ORDER BY (tm); -- SETTINGS index_granularity_bytes = 50; --, min_index_granularity_bytes = 40; |
There was a problem hiding this comment.
Does the table with adaptive index granularity support secondary index now?
There was a problem hiding this comment.
No, loading marks of index files has an exception if enable adaptive index granularity
Clark0
approved these changes
Mar 10, 2023
WillemJiang
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: [placeholder]
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
ALTER table MATERIALIZE INDEX ...Closes #102
If you are doing this for the first time, it's recommended to read the lightweight Contributing to ByConity Documentation guide first.