Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix thread map related issue #128

Merged
merged 7 commits into from
Mar 17, 2023
Merged

fix: Fix thread map related issue #128

merged 7 commits into from
Mar 17, 2023

Conversation

dmthuc
Copy link
Collaborator

@dmthuc dmthuc commented Mar 3, 2023

I hereby agree to the terms of the CLA available at: [placeholder]

Changelog category (leave one):

  • Bug Fix

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

...

Detailed description / Documentation draft:

...

If you are doing this for the first time, it's recommended to read the lightweight Contributing to ByConity Documentation guide first.

@CLAassistant
Copy link

CLAassistant commented Mar 3, 2023

CLA assistant check
All committers have signed the CLA.

@hustnn
Copy link
Contributor

hustnn commented Mar 3, 2023

Trying to fix #123

@vivek-debug
Copy link
Contributor

Shall we support the feature at a later date?

@hustnn
Copy link
Contributor

hustnn commented Mar 16, 2023

@vivek-debug sure, we can make this pass the ci and merge it first. Currently, DM is flooded by this error.

Copy link
Contributor

@vivek-debug vivek-debug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Added the required class but not used at the moment.

@vivek-debug
Copy link
Contributor

cc @hustnn

@vivek-debug vivek-debug merged commit 4a681ad into master Mar 17, 2023
@WillemJiang WillemJiang changed the title fix thread map fix: Fix thread map related issue May 17, 2023
@dmthuc dmthuc deleted the dao_fix_thread_map branch August 31, 2023 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants