feat: Enable data preload write through #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hustnn
reviewed
Mar 30, 2023
hustnn
reviewed
Mar 30, 2023
| @@ -237,7 +237,7 @@ void CloudMergeTreeBlockOutputStream::writeSuffixImpl() | |||
| { | |||
| /// auto testlog = std::make_shared<TestLog>(const_cast<Context &>(context)); | |||
| /// TEST_START(testlog); | |||
| /// tryPreloadChecksumsAndPrimaryIndex(storage, std::move(preload_parts), ManipulationType::Insert, context); | |||
| tryPreload(context, storage, preload_parts); | |||
There was a problem hiding this comment.
Do we need to support finish the preload before parts become visible?
hustnn
reviewed
Mar 30, 2023
| @@ -483,4 +484,37 @@ void CnchDataWriter::publishStagedParts( | |||
| commitDumpedParts(items); | |||
| } | |||
|
|
|||
| void tryPreload( | |||
There was a problem hiding this comment.
How does mergemutate task preload the part？
Clark0
force-pushed
the
preload-dev
branch
4 times, most recently
from
5b5d638
to
f4778d7
Compare
hustnn
reviewed
Apr 6, 2023
| /// tryPreloadChecksumsAndPrimaryIndex(storage, std::move(preload_parts), ManipulationType::Insert, context); | ||
| /// TEST_END(testlog, "Finish tryPreloadChecksumsAndPrimaryIndex in batch mode"); | ||
| } | ||
| cnch_writer.preload(preload_parts); |
There was a problem hiding this comment.
Is it duplicated? since it has been preloaded before commit.
There was a problem hiding this comment.
where do you refer to the previous preload? here it's actually preload after commit.
There was a problem hiding this comment.
I see the preload is also called such as commit part.
hustnn
approved these changes
Apr 11, 2023
WillemJiang
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog category :
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Write through cache strategy,
add new settings to enable writing to disk cache while inserting data
...
Documentation entry for user-facing changes