feat: cnchhive support read ORC format (preview) #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
zhangsiqi.awesome seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
|
@fantasy12345zsq Can you update your GitHub account with the email you use in the Git commit？ |
Clark0
reviewed
Apr 5, 2023
src/Storages/Hive/HiveDataPart.h
Outdated
| size_t getTotalRowGroups() const; | ||
| size_t getTotalStripes() const; | ||
| arrow::Status tryGetTotalRowGroups(size_t & num_row_groups) const; | ||
| arrow::Status tryGetTotalStripes(size_t & res) const; |
Clark0
reviewed
Apr 6, 2023
| ORCBlockInputFormat( | ||
| ReadBuffer & in_, | ||
| Block header_, | ||
| const std::map<String, String> & partition_kv_ = {}); |
There was a problem hiding this comment.
can consider use IDataType::createColumnConst outside of the BlockInputFormat, instead of passing in partition_kv
hustnn
changed the title
fantasy12345zsq
force-pushed
the
cnchhive_support_orc
branch
from
88cdfeb
to
3513e2a
Compare
fantasy12345zsq
force-pushed
the
cnchhive_support_orc
branch
from
3513e2a
to
41fb0eb
Compare
Clark0
approved these changes
May 16, 2023
hustnn
changed the title
canhld94
approved these changes
May 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog category :
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Add support for ORC format in hive engine. Noted, it will be a preview feature in GA.
...
Documentation entry for user-facing changes