perf: Predict hash table size for aggregation #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hustnn
reviewed
Apr 27, 2023
| auto & tbl = expr.database_and_table_name->as<DB::ASTTableIdentifier &>(); | ||
| auto db_name = tbl.name_parts.size() == 2 ? tbl.name_parts[0] : ""; | ||
| auto tb_name = tbl.name_parts.size() == 2 ? tbl.name_parts[1] : tbl.name_parts[0]; | ||
| /// Table name in worker has name like t_441011350722576384 with last 18 characters |
There was a problem hiding this comment.
Maybe we can use table uuid in future.
hustnn
reviewed
Apr 27, 2023
| } | ||
| } | ||
| } | ||
| hash.update(tables->getTreeHash()); |
There was a problem hiding this comment.
how the table renaming is updated?
There was a problem hiding this comment.
I forgot to push a commit. Just push it now.
hustnn
approved these changes
Apr 27, 2023
WillemJiang
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog category :
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Documentation entry for user-facing changes