feat: Add S3 rename tool #490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
linkwk7
reviewed
Jul 14, 2023
| S3::Model::CopyObjectOutcome outcome = client.CopyObject(request); | ||
| if (!outcome.IsSuccess()) { | ||
| const S3::S3Error &err = outcome.GetError(); | ||
| std::cerr << "Error: CopyObject: " << |
There was a problem hiding this comment.
Use Poco::Logger to print logs
linkwk7
reviewed
Jul 14, 2023
| boost::asio::thread_pool thread_pool(threadNum); | ||
| for (S3::Model::Object &object: objects) { | ||
| // root_prefix/table_uuid/part_uuid/name | ||
| String from_key = object.GetKey(); |
There was a problem hiding this comment.
The key will have format of prefix/table_uuid/part_uuid/data, can check if table_uuid & part_uuid is a valid uuid here by ReaderHelpers.h:tryReadUUIDText
linkwk7
reviewed
Jul 14, 2023
|
hi @Alima777 , pls sign the CLA |
|
Hi, @hustnn , it's signed now. |
linkwk7
approved these changes
Jul 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tool is used to delete table_uuid from the key of s3 objects. Only patterns like "root_prefix/table_uuid/part_uuid/key" will be renamed, other objects will keep like before.