-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
refactoring problem 55 using clean code thoughts
- Loading branch information
Showing
3 changed files
with
107 additions
and
58 deletions.
There are no files selected for viewing
80 changes: 80 additions & 0 deletions
80
src/main/java/clean/code/problems/LychrelNumberProverUntil.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,80 @@ | ||
package clean.code.problems; | ||
|
||
import java.math.BigInteger; | ||
import java.util.ArrayList; | ||
import java.util.List; | ||
|
||
public class LychrelNumberProverUntil | ||
{ | ||
private int largestNumberToProve; | ||
|
||
public LychrelNumberProverUntil(int largestNumberToProve) | ||
{ | ||
this.largestNumberToProve = largestNumberToProve; | ||
} | ||
|
||
public static void main(String[] args) | ||
{ | ||
int lychrelNumberCounter = new LychrelNumberProverUntil(10000).countLychrelNumbers(); | ||
System.out.println("How many? " + lychrelNumberCounter); | ||
} | ||
|
||
public int countLychrelNumbers() | ||
{ | ||
List<BigInteger> lychrelNumbers = new ArrayList<BigInteger>(); | ||
|
||
for (int i = 1; i <= largestNumberToProve; i++) | ||
{ | ||
boolean isLychrelNumber = sumItsReversedValueUntilProveItsLychrel(BigInteger.valueOf(i)); | ||
if (isLychrelNumber) | ||
{ | ||
lychrelNumbers.add(BigInteger.valueOf(i)); | ||
} | ||
} | ||
|
||
return lychrelNumbers.size(); | ||
} | ||
|
||
private boolean sumItsReversedValueUntilProveItsLychrel(BigInteger numberToVerify) | ||
{ | ||
for (int i = 0; i < 50; i++) | ||
{ | ||
BigInteger sumWithReversedValue = sumWithItsReversedValue(numberToVerify); | ||
if (isPalindrome(sumWithReversedValue)) | ||
{ | ||
return false; | ||
} | ||
else | ||
{ | ||
numberToVerify = sumWithReversedValue; | ||
} | ||
} | ||
|
||
return true; | ||
} | ||
|
||
private BigInteger sumWithItsReversedValue(BigInteger numberToVerify) | ||
{ | ||
BigInteger reversedNumber = reverseNumber(numberToVerify); | ||
BigInteger reversedSum = numberToVerify.add(reversedNumber); | ||
|
||
return reversedSum; | ||
} | ||
|
||
private boolean isPalindrome(BigInteger number) | ||
{ | ||
String numberAsString = String.valueOf(number); | ||
String numberAsReversedString = String.valueOf(reverseNumber(number)); | ||
|
||
return numberAsReversedString.equals(numberAsString); | ||
} | ||
|
||
private BigInteger reverseNumber(BigInteger toReverse) | ||
{ | ||
String resultString = String.valueOf(toReverse); | ||
String resultReverse = new StringBuffer(resultString).reverse().toString(); | ||
|
||
return new BigInteger(resultReverse); | ||
} | ||
|
||
} |
This file was deleted.
Oops, something went wrong.
27 changes: 27 additions & 0 deletions
27
src/test/java/clean/code/problems/LychrelNumberProverUntilTest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
package clean.code.problems; | ||
|
||
import static org.junit.Assert.*; | ||
|
||
import org.junit.Test; | ||
|
||
|
||
public class LychrelNumberProverUntilTest | ||
{ | ||
|
||
@Test | ||
public void sholdCount249LychrelNumbersUntil10000() | ||
{ | ||
LychrelNumberProverUntil lychrelNumbersDiscover = new LychrelNumberProverUntil(10000); | ||
int lychrelNumbersCounter = lychrelNumbersDiscover.countLychrelNumbers(); | ||
assertEquals(lychrelNumbersCounter, 249); | ||
} | ||
|
||
@Test | ||
public void sholdCount13LychrelNumbersUntil1000() | ||
{ | ||
LychrelNumberProverUntil lychrelNumbersDiscover = new LychrelNumberProverUntil(1000); | ||
int lychrelNumbersCounter = lychrelNumbersDiscover.countLychrelNumbers(); | ||
assertEquals(lychrelNumbersCounter, 13); | ||
} | ||
|
||
} |