bug fix related in #2

ByIvo · Jan 31, 2018 · 5e43d12 · 5e43d12
1 parent e8e64d1
commit 5e43d12
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 12 deletions.
diff --git a/src/configfile_finder/configfile-finder-test.js b/src/configfile_finder/configfile-finder-test.js
@@ -61,10 +61,10 @@ describe('Configfile finder', function () {
     fs.readdirSync.restore();
   });
 
-  it('If the file does not exists, throw an exception', function () {
-    expect(function () {
-      configfileFinder.from(fakeNoConfigfilePath, configFilename);
-    }).to.throw('The path \''+ path.join(fakeNoConfigfilePath, configFilename) + '\' does not exists');
+  it('If the file does not exists, just ignore it and return false', function () {
+    var projectInfo = configfileFinder.from(fakeNoConfigfilePath, configFilename);
+
+    expect(projectInfo).to.equal(false);
   });
 
   it('Should read the file as property object and returns it', function () {

diff --git a/src/configfile_finder/configfile-finder.js b/src/configfile_finder/configfile-finder.js
@@ -16,16 +16,17 @@ function readProjectInfoAndKeepSearching(dirPath, configFilename, isFirstCall) {
     base: configFilename
   });
 
-  if(!fs.existsSync(configfilePath)) {
-    throw Error('The path \''+ configfilePath + '\' does not exists');
-  }
+  if(fs.existsSync(configfilePath)) {
+
+    var projectInfo =  configfileReader.readFrom(configfilePath);
 
-  var projectInfo =  configfileReader.readFrom(configfilePath);
-
-  projectInfo.root = isFirstCall;
-  projectInfo.branches = readChildrenFrom(dirPath, configFilename);
+    projectInfo.root = isFirstCall;
+    projectInfo.branches = readChildrenFrom(dirPath, configFilename);
 
-  return projectInfo;
+    return projectInfo;
+  } else {
+    return false;
+  }
 }
 
 function readChildrenFrom(dirPath, configFilename) {