Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of Workflow API #100

Merged
merged 7 commits into from
Jan 27, 2023
Merged

Conversation

alfnav
Copy link
Contributor

@alfnav alfnav commented Jan 8, 2023

Full implementation of the Bynder Workflow API:

  • Workflow campaigns
  • Workflow jobs
  • Workflow metaproperties
  • Workflow users
  • Workflow groups

@coveralls
Copy link

coveralls commented Jan 8, 2023

Coverage Status

Coverage: 56.341%. Remained the same when pulling e776009 on alfnav:workflow into 170a564 on Bynder:master.

@TimBloembergen
Copy link

Thanks @alfnav. We will review this PR and will keep you posted on what we will do with it.

Copy link
Contributor

@Arpit-Sharma-USC Arpit-Sharma-USC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work @alfnav! Just left some formatting and documentation suggestions for you.

@TimBloembergen
Copy link

Hi @alfnav could you please review @Arpit-Sharma-USC 's comments and add the changes requested? We would like to merge these new features and make a new release this week. Thanks!

@alfnav
Copy link
Contributor Author

alfnav commented Jan 25, 2023

Hello @TimBloembergen , I am so sorry for the delay in come back to you, I was quite busy at work and i could not find time to do the required changed. Meanwhile I can see that @Arpit-Sharma-USC has already done some of the formatting and documentation changes, sorry for not including this at the beginning. I think that there are also some extra documentation which can be added in the bynder API class and I can do that at a later stage together with other changes in the SDK which I will push if this is ok for you. Thanks!

@TimBloembergen
Copy link

Hi @alfnav No worries at all, I indeed asked if Arpit could do the changes so we're not blocked for a release. We really appreciate the work and effort you put into this. I believe this is the biggest contribution someone has ever done on any of our SDK's. We will create a new release, if you want to add more documentation to it we would appreciate it so we can merge that at a later stage.

Copy link
Contributor

@betacar betacar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leaving aside the outdated copyright headers, LGTM! 🐑 🇮🇹

@Arpit-Sharma-USC Arpit-Sharma-USC merged commit 7483835 into Bynder:master Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants