-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementation of Workflow API #100
Conversation
Thanks @alfnav. We will review this PR and will keep you posted on what we will do with it. |
src/main/java/com/bynder/sdk/service/workflow/WorkflowService.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great work @alfnav! Just left some formatting and documentation suggestions for you.
Hi @alfnav could you please review @Arpit-Sharma-USC 's comments and add the changes requested? We would like to merge these new features and make a new release this week. Thanks! |
Hello @TimBloembergen , I am so sorry for the delay in come back to you, I was quite busy at work and i could not find time to do the required changed. Meanwhile I can see that @Arpit-Sharma-USC has already done some of the formatting and documentation changes, sorry for not including this at the beginning. I think that there are also some extra documentation which can be added in the bynder API class and I can do that at a later stage together with other changes in the SDK which I will push if this is ok for you. Thanks! |
Hi @alfnav No worries at all, I indeed asked if Arpit could do the changes so we're not blocked for a release. We really appreciate the work and effort you put into this. I believe this is the biggest contribution someone has ever done on any of our SDK's. We will create a new release, if you want to add more documentation to it we would appreciate it so we can merge that at a later stage. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Leaving aside the outdated copyright headers, LGTM! 🐑 🇮🇹
Full implementation of the Bynder Workflow API: