[API-789] Fix async unit tests #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elseee
commented
Jan 31, 2022
| const { fileId, mediaId, additional } = data; | ||
| const { fileId, mediaId, additional, brandId } = data; | ||
|
|
||
| if (!brandId && !mediaId) { |
There was a problem hiding this comment.
We need either the brandId (for a new asset) or the mediaId (for a newer version of an existing asset) to save an asset.
There was a problem hiding this comment.
But this condition is requesting both parameters to be defined.
There was a problem hiding this comment.
The condition is checking if both of them are undefined, hence the !
elseee
commented
Jan 31, 2022
| @@ -131,77 +129,65 @@ describe('#getToken', () => { | |||
|
|
|||
| describe('#uploadFile', () => { | |||
| it('throws an error with no brand ID', () => { | |||
| bynder.uploadFile({ | |||
| return expect(bynder.uploadFile({ | |||
There was a problem hiding this comment.
To make sure that jest waits for the promise to complete we need to either return the promise from the test, or await it. Also by the expect(...).rejects pattern we ensure that the test fails if the promise were to resolve.
betacar
reviewed
Jan 31, 2022
betacar
reviewed
Jan 31, 2022
added 2 commits
January 31, 2022 16:33
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bynder.atlassian.net/browse/API-789