Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GC-4107] Integration functions in PHP 8.3 #73

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[GC-4107] Integration functions in PHP 8.3 #73

wants to merge 2 commits into from

Conversation

Gallmond
Copy link
Contributor

@Gallmond Gallmond commented Jan 31, 2024 •
edited

Updates the composer.json to enforce 7.x or 8.0 - 8.3.* versions.

Functions as expected in an 8.3 environment.

Works out of the box as the only non-dev requirements are friendly to higher levels of php:

  • techcrunch/wp-async-task no php requirement (single script very vanilla old school php)
  • ralouphie/mimey requires >=5.3

Tested locally for:

  • Login
  • Create new mappings
  • Open and edit new mappings
  • Pull & Push from in-post editor

@Gallmond Gallmond marked this pull request as ready for review January 31, 2024 16:17
@Gallmond Gallmond changed the title Integrations functions in PHP 8.3 [GC-4107] Integration functions in PHP 8.3 Jan 31, 2024
@Gallmond Gallmond mentioned this pull request Feb 2, 2024
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HughbertD HughbertD Awaiting requested review from HughbertD

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@Gallmond