Now we are truly single-threaded when threads = 1

Byron · Mar 15, 2020 · b7ed2bb · b7ed2bb
1 parent 394e261
commit b7ed2bb
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/README.md b/README.md
@@ -69,7 +69,7 @@ dua interactive
 
 #### ✅ v2.3.5 Fast exit from interactive mode for a responsive exit; dependency updates (except jwalk)
 
-#### ✅ v2.3.4 YANKED - jwalk 0.5.0 shows a performance regression
+#### ✅ v2.3.4 YANKED - jwalk 0.5.0 wasn't used correctly which led to a performance regression
 
 #### ✅ v2.3.3 YANKED - journey tests failed to changed method signature
 

diff --git a/src/common.rs b/src/common.rs
@@ -175,10 +175,10 @@ impl WalkOptions {
                     }
                 })
             })
-            .parallelism(if self.threads == 0 {
-                jwalk::Parallelism::RayonDefaultPool
-            } else {
-                jwalk::Parallelism::RayonNewPool(self.threads)
+            .parallelism(match self.threads {
+                0 => jwalk::Parallelism::RayonDefaultPool,
+                1 => jwalk::Parallelism::Serial,
+                _ => jwalk::Parallelism::RayonNewPool(self.threads),
             })
     }
 }