Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ctrl + r doesn't work in interactive mode #33

Closed
ms747 opened this issue Feb 21, 2020 · 5 comments
Closed

Ctrl + r doesn't work in interactive mode #33

ms747 opened this issue Feb 21, 2020 · 5 comments
Labels
question Further information is requested

Comments

@ms747
Copy link

ms747 commented Feb 21, 2020

As the title suggests after marking files, Ctrl + r has no effects (deleting).
Tried both release version and cargo compiled version.

@Byron Byron added the question Further information is requested label Feb 22, 2020
@Byron
Copy link
Owner

Byron commented Feb 22, 2020

Does it keep being an issue if you follow these steps?

Select something with space or d
Screenshot 2020-02-22 at 09 46 08
…then hit the <tab> key…
Screenshot 2020-02-22 at 09 46 19
…and now hitting ctrl+r will work as advertised.

The process is intentionally forcing the user to perform multiple steps to make accidental deletion less likely.

If this doesn't fix your issue it may be a bug, which is when you can provide clear steps to reproduce it and we can reopen the issue.

Hope that helps.

@Byron Byron closed this as completed Feb 22, 2020
@pergamomo
Copy link

Hi!

First of all thank you for a really nice tool!

I sort of ran into the same issue but only by finding this thread I figured out how to delete the selected files.

Maybe it would be an idea to show a hint in the yellow text field at the top or write it as the first bullet point in the help text.

Just a suggestion.

@Byron
Copy link
Owner

Byron commented Apr 26, 2023

Yes, I think that could be a simple improvement with a lot of potential to reduce initial confusion on how to delete files.

Would you like to help with that? It's src/interactive/widgets/help.rs that would need an adjustment.

@sommerper
Copy link
Contributor

@Byron Sure, I'll do it. (Just not with my work account from above) ;-)

@sommerper
Copy link
Contributor

@Byron I'd like to commit a branch for review.

Byron added a commit that referenced this issue May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

4 participants