Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use binary format by default (except on macOS) #150

Merged
merged 1 commit into from
Mar 12, 2023

Conversation

tessus
Copy link
Contributor

@tessus tessus commented Mar 12, 2023

fixes #85

@Byron Byron merged commit 3ccf204 into Byron:main Mar 12, 2023
@Byron
Copy link
Owner

Byron commented Mar 12, 2023

Thanks a lot! And I learned something as well, as I wasn't aware of std::env::consts (but used conditional compilation for these things as a binary is built per platform anyway).

@tessus
Copy link
Contributor Author

tessus commented Mar 12, 2023

You are welcome. Using conditional compilation is a mistake in most cases. e.g. for something like this it makes no sense.

Conditional compilation makes sense for libraries when the functions/methods are fundamentally different and are thousand of lines long.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider using binary (KiB, MiB) format by default.
2 participants