Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: refresh all items in view / selected item #219

Merged
merged 17 commits into from Jan 17, 2024
Merged

feat: refresh all items in view / selected item #219

merged 17 commits into from Jan 17, 2024

Commits on Jan 10, 2024

  1. make WalkOptions available in State so it can re-use it for additiona… 

    …l walks.
    @Byron @piotrwach
    Byron authored and piotrwach committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    0ad90ba View commit details
    Browse the repository at this point in the history

  2. add R to trigger a full refresh (PoC) 

    - it doesn't deal with sub-trees - for that it would need awareness of the
  method that integrates tree events.
- selection handling isn't implemented, so the selection just disappears.
- if the root to be refreshed still exists, it should probably keep it selected
  instead of removing it.
- it seems useful to have some control over the scope of the refresh, and these
  are sketched with the `Refresh` enum.
    @Byron @piotrwach
    Byron authored and piotrwach committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    30d8dd5 View commit details
    Browse the repository at this point in the history

Commits on Jan 14, 2024

  1. Traverse children vs parent & fix parent node size after refresh

    @piotrwach
    piotrwach committed Jan 14, 2024
    Configuration menu
    Copy the full SHA
    226cbb8 View commit details
    Browse the repository at this point in the history

  2. Moved traversal stats to separate type

    @piotrwach
    piotrwach committed Jan 14, 2024
    Configuration menu
    Copy the full SHA
    969e64b View commit details
    Browse the repository at this point in the history

  3. Fix traversal stats

    @piotrwach
    piotrwach committed Jan 14, 2024
    Configuration menu
    Copy the full SHA
    96ef242 View commit details
    Browse the repository at this point in the history

  4. Fix file count

    @piotrwach
    piotrwach committed Jan 14, 2024
    Configuration menu
    Copy the full SHA
    eeae2bc View commit details
    Browse the repository at this point in the history

  5. Refresh all in view vs selected

    @piotrwach
    piotrwach committed Jan 14, 2024
    Configuration menu
    Copy the full SHA
    06ee3ab View commit details
    Browse the repository at this point in the history

  6. Remove debug comments

    @piotrwach
    piotrwach committed Jan 14, 2024
    Configuration menu
    Copy the full SHA
    9f37e1c View commit details
    Browse the repository at this point in the history

  7. Fixed tests

    @piotrwach
    piotrwach committed Jan 14, 2024
    Configuration menu
    Copy the full SHA
    69f14af View commit details
    Browse the repository at this point in the history

  8. Fix updating item count

    @piotrwach
    piotrwach committed Jan 14, 2024
    Configuration menu
    Copy the full SHA
    13614a9 View commit details
    Browse the repository at this point in the history

  9. Exit glob mode if view root is the same as glob root

    @piotrwach
    piotrwach committed Jan 14, 2024
    Configuration menu
    Copy the full SHA
    253f720 View commit details
    Browse the repository at this point in the history

  10. Fix tests

    @piotrwach
    piotrwach committed Jan 14, 2024
    Configuration menu
    Copy the full SHA
    6b24912 View commit details
    Browse the repository at this point in the history

  11. cargo clippy & fmt

    @piotrwach
    piotrwach committed Jan 14, 2024
    Configuration menu
    Copy the full SHA
    ad7abd8 View commit details
    Browse the repository at this point in the history

  12. Various updates based on the code review feedback: 

    * Added keys to the Help page.
* Starting a new traversal is blocked if another traversal is already running.
* Glob search is blocked if traversal is already running.
    @piotrwach
    piotrwach committed Jan 14, 2024
    Configuration menu
    Copy the full SHA
    c3d665d View commit details
    Browse the repository at this point in the history

  13. Preserve selected element after refresh

    @piotrwach
    piotrwach committed Jan 14, 2024
    Configuration menu
    Copy the full SHA
    99e5384 View commit details
    Browse the repository at this point in the history

Commits on Jan 17, 2024

  1. make Shift+r do more than 'r' 

    It's more effort, which should be reflrected in the amount of work
done as well, which I think is more intuitive.
    @Byron
    Byron committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    f1fc13e View commit details
    Browse the repository at this point in the history

  2. refactor 

    - show messages that indicate why sometimes key-presses are ignored
- maintain previous selection in a clearer fashion
- maintain seelction from glob-mode as well
- switch title to `entry` as it's not only 'file's there, also directories.
- also show how many entries there are visible
    @Byron
    Byron committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    18a725d View commit details
    Browse the repository at this point in the history