cargo clippy

.github/workflows/rust.yml

@@ -13,7 +13,7 @@ jobs:
     steps:
     - uses: actions/checkout@v2
     - name: clippy
-      run: cargo clippy
+      run: cargo clippy --all
     - name: fmt
       run: cargo fmt --all -- --check
     - name: test

git-core/src/init.rs

@@ -26,36 +26,34 @@ quick_error! {
     }
 }
 
-const GIT_DIR_NAME: &'static str = ".git";
+const GIT_DIR_NAME: &str = ".git";
 
-const TPL_INFO_EXCLUDE: &'static [u8] = include_bytes!("./assets/baseline-init/info/exclude");
-const TPL_HOOKS_APPLYPATCH_MSG: &'static [u8] =
+const TPL_INFO_EXCLUDE: &[u8] = include_bytes!("./assets/baseline-init/info/exclude");
+const TPL_HOOKS_APPLYPATCH_MSG: &[u8] =
     include_bytes!("./assets/baseline-init/hooks/applypatch-msg.sample");
-const TPL_HOOKS_COMMIT_MSG: &'static [u8] =
+const TPL_HOOKS_COMMIT_MSG: &[u8] =
     include_bytes!("./assets/baseline-init/hooks/commit-msg.sample");
-const TPL_HOOKS_FSMONITOR_WATCHMAN: &'static [u8] =
+const TPL_HOOKS_FSMONITOR_WATCHMAN: &[u8] =
     include_bytes!("./assets/baseline-init/hooks/fsmonitor-watchman.sample");
-const TPL_HOOKS_POST_UPDATE: &'static [u8] =
+const TPL_HOOKS_POST_UPDATE: &[u8] =
     include_bytes!("./assets/baseline-init/hooks/post-update.sample");
-const TPL_HOOKS_PRE_APPLYPATCH: &'static [u8] =
+const TPL_HOOKS_PRE_APPLYPATCH: &[u8] =
     include_bytes!("./assets/baseline-init/hooks/pre-applypatch.sample");
-const TPL_HOOKS_PRE_COMMIT: &'static [u8] =
+const TPL_HOOKS_PRE_COMMIT: &[u8] =
     include_bytes!("./assets/baseline-init/hooks/pre-commit.sample");
-const TPL_HOOKS_PRE_MERGE_COMMIT: &'static [u8] =
+const TPL_HOOKS_PRE_MERGE_COMMIT: &[u8] =
     include_bytes!("./assets/baseline-init/hooks/pre-merge-commit.sample");
-const TPL_HOOKS_PRE_PUSH: &'static [u8] =
-    include_bytes!("./assets/baseline-init/hooks/pre-push.sample");
-const TPL_HOOKS_PRE_REBASE: &'static [u8] =
+const TPL_HOOKS_PRE_PUSH: &[u8] = include_bytes!("./assets/baseline-init/hooks/pre-push.sample");
+const TPL_HOOKS_PRE_REBASE: &[u8] =
     include_bytes!("./assets/baseline-init/hooks/pre-rebase.sample");
-const TPL_HOOKS_PRE_RECEIVE: &'static [u8] =
+const TPL_HOOKS_PRE_RECEIVE: &[u8] =
     include_bytes!("./assets/baseline-init/hooks/pre-receive.sample");
-const TPL_HOOKS_PREPARE_COMMIT_MSG: &'static [u8] =
+const TPL_HOOKS_PREPARE_COMMIT_MSG: &[u8] =
     include_bytes!("./assets/baseline-init/hooks/prepare-commit-msg.sample");
-const TPL_HOOKS_UPDATE: &'static [u8] =
-    include_bytes!("./assets/baseline-init/hooks/update.sample");
-const TPL_CONFIG: &'static [u8] = include_bytes!("./assets/baseline-init/config");
-const TPL_DESCRIPTION: &'static [u8] = include_bytes!("./assets/baseline-init/description");
-const TPL_HEAD: &'static [u8] = include_bytes!("./assets/baseline-init/HEAD");
+const TPL_HOOKS_UPDATE: &[u8] = include_bytes!("./assets/baseline-init/hooks/update.sample");
+const TPL_CONFIG: &[u8] = include_bytes!("./assets/baseline-init/config");
+const TPL_DESCRIPTION: &[u8] = include_bytes!("./assets/baseline-init/description");
+const TPL_HEAD: &[u8] = include_bytes!("./assets/baseline-init/HEAD");
 
 struct PathCursor<'a>(&'a mut PathBuf);
 

src/main.rs

@@ -1,5 +1,4 @@
 use anyhow::{Context, Result};
-use git_core;
 use structopt::StructOpt;
 
 mod options {