[clone] FAIL: try to communicate error codes after request

Byron · Aug 23, 2020 · 2501ddd · 2501ddd
1 parent 174baa7
commit 2501ddd
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 2 deletions.
diff --git a/git-transport/src/client/http/curl.rs b/git-transport/src/client/http/curl.rs
@@ -31,7 +31,6 @@ impl curl::easy::Handler for Handler {
     }
 
     fn header(&mut self, data: &[u8]) -> bool {
-        // TODO: check for HTTP status!
         match self.send_header.as_mut() {
             Some(writer) => writer.write_all(data).is_ok(),
             None => false,
@@ -185,7 +184,17 @@ fn new_remote_curl() -> (
                 let handler = handle.get_mut();
                 handler.receive_body.take();
                 handler.send_header.take();
-                handler.send_data.take();
+                if let Some(data) = handler.send_data.take() {
+                    let status = handle.response_code()?;
+                    if status < 200 || status > 299 {
+                        data.channel
+                            .try_send(Err(io::Error::new(
+                                io::ErrorKind::Other,
+                                format!("Received HTTP status {}", status),
+                            )))
+                            .ok();
+                    }
+                }
             }
         }
         Ok(())

diff --git a/git-transport/tests/fixtures/v1/http-handshake.response b/git-transport/tests/fixtures/v1/http-handshake.response