make trait parameter more open, no need for 'static

Note that this is already a breaking change earlier.
Byron · Nov 9, 2022 · 68dc86f · 68dc86f
1 parent b9a5eea
commit 68dc86f
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 11 deletions.
diff --git a/git-protocol/src/fetch/delegate.rs b/git-protocol/src/fetch/delegate.rs
@@ -56,7 +56,7 @@ pub trait DelegateBlocking {
         &mut self,
         _server: &Capabilities,
         _arguments: &mut Vec<BString>,
-        _features: &mut Vec<(&str, Option<Cow<'static, str>>)>,
+        _features: &mut Vec<(&str, Option<Cow<'_, str>>)>,
     ) -> std::io::Result<LsRefsAction> {
         Ok(LsRefsAction::Continue)
     }
@@ -76,7 +76,7 @@ pub trait DelegateBlocking {
         &mut self,
         _version: git_transport::Protocol,
         _server: &Capabilities,
-        _features: &mut Vec<(&str, Option<Cow<'static, str>>)>,
+        _features: &mut Vec<(&str, Option<Cow<'_, str>>)>,
         _refs: &[Ref],
     ) -> std::io::Result<Action> {
         Ok(Action::Continue)
@@ -126,7 +126,7 @@ impl<T: DelegateBlocking> DelegateBlocking for Box<T> {
         &mut self,
         _server: &Capabilities,
         _arguments: &mut Vec<BString>,
-        _features: &mut Vec<(&str, Option<Cow<'static, str>>)>,
+        _features: &mut Vec<(&str, Option<Cow<'_, str>>)>,
     ) -> io::Result<LsRefsAction> {
         self.deref_mut().prepare_ls_refs(_server, _arguments, _features)
     }
@@ -135,7 +135,7 @@ impl<T: DelegateBlocking> DelegateBlocking for Box<T> {
         &mut self,
         _version: git_transport::Protocol,
         _server: &Capabilities,
-        _features: &mut Vec<(&str, Option<Cow<'static, str>>)>,
+        _features: &mut Vec<(&str, Option<Cow<'_, str>>)>,
         _refs: &[Ref],
     ) -> io::Result<Action> {
         self.deref_mut().prepare_fetch(_version, _server, _features, _refs)
@@ -160,7 +160,7 @@ impl<T: DelegateBlocking> DelegateBlocking for &mut T {
         &mut self,
         _server: &Capabilities,
         _arguments: &mut Vec<BString>,
-        _features: &mut Vec<(&str, Option<Cow<'static, str>>)>,
+        _features: &mut Vec<(&str, Option<Cow<'_, str>>)>,
     ) -> io::Result<LsRefsAction> {
         self.deref_mut().prepare_ls_refs(_server, _arguments, _features)
     }
@@ -169,7 +169,7 @@ impl<T: DelegateBlocking> DelegateBlocking for &mut T {
         &mut self,
         _version: git_transport::Protocol,
         _server: &Capabilities,
-        _features: &mut Vec<(&str, Option<Cow<'static, str>>)>,
+        _features: &mut Vec<(&str, Option<Cow<'_, str>>)>,
         _refs: &[Ref],
     ) -> io::Result<Action> {
         self.deref_mut().prepare_fetch(_version, _server, _features, _refs)

diff --git a/git-protocol/tests/fetch/mod.rs b/git-protocol/tests/fetch/mod.rs
@@ -28,7 +28,7 @@ impl fetch::DelegateBlocking for CloneDelegate {
         &mut self,
         _version: git_transport::Protocol,
         _server: &Capabilities,
-        _features: &mut Vec<(&str, Option<Cow<'static, str>>)>,
+        _features: &mut Vec<(&str, Option<Cow<'_, str>>)>,
         _refs: &[fetch::Ref],
     ) -> io::Result<Action> {
         match self.abort_with.take() {
@@ -72,7 +72,7 @@ impl fetch::DelegateBlocking for CloneRefInWantDelegate {
         &mut self,
         _server: &Capabilities,
         _arguments: &mut Vec<BString>,
-        _features: &mut Vec<(&str, Option<Cow<'static, str>>)>,
+        _features: &mut Vec<(&str, Option<Cow<'_, str>>)>,
     ) -> io::Result<LsRefsAction> {
         Ok(LsRefsAction::Skip)
     }
@@ -81,7 +81,7 @@ impl fetch::DelegateBlocking for CloneRefInWantDelegate {
         &mut self,
         _version: git_transport::Protocol,
         _server: &Capabilities,
-        _features: &mut Vec<(&str, Option<Cow<'static, str>>)>,
+        _features: &mut Vec<(&str, Option<Cow<'_, str>>)>,
         refs: &[fetch::Ref],
     ) -> io::Result<Action> {
         self.refs = refs.to_owned();
@@ -111,7 +111,7 @@ impl fetch::DelegateBlocking for LsRemoteDelegate {
         &mut self,
         _server: &Capabilities,
         _arguments: &mut Vec<BString>,
-        _features: &mut Vec<(&str, Option<Cow<'static, str>>)>,
+        _features: &mut Vec<(&str, Option<Cow<'_, str>>)>,
     ) -> std::io::Result<LsRefsAction> {
         match self.abort_with.take() {
             Some(err) => Err(err),
@@ -122,7 +122,7 @@ impl fetch::DelegateBlocking for LsRemoteDelegate {
         &mut self,
         _version: git_transport::Protocol,
         _server: &Capabilities,
-        _features: &mut Vec<(&str, Option<Cow<'static, str>>)>,
+        _features: &mut Vec<(&str, Option<Cow<'_, str>>)>,
         refs: &[fetch::Ref],
     ) -> io::Result<fetch::Action> {
         self.refs = refs.to_owned();