higher-performance 'seen' tracking for commit traversal (#298)

Byron · Apr 5, 2022 · 8c530d1 · 8c530d1
1 parent 514e468
commit 8c530d1
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 5 deletions.
diff --git a/Cargo.lock b/Cargo.lock
diff --git a/git-traverse/Cargo.toml b/git-traverse/Cargo.toml
@@ -17,6 +17,7 @@ doctest = false
 git-hash = { version = "^0.9.3", path = "../git-hash" }
 git-object = { version = "^0.18.0", path = "../git-object" }
 quick-error = "2.0.0"
+hash_hasher = "2.0.3"
 
 [dev-dependencies]
 git-testtools = { path = "../tests/tools" }

diff --git a/git-traverse/src/commit.rs b/git-traverse/src/commit.rs
@@ -41,10 +41,7 @@ impl Default for Sorting {
 
 ///
 pub mod ancestors {
-    use std::{
-        borrow::BorrowMut,
-        collections::{BTreeSet, VecDeque},
-    };
+    use std::{borrow::BorrowMut, collections::VecDeque};
 
     use git_hash::{oid, ObjectId};
     use git_object::CommitRefIter;
@@ -74,7 +71,7 @@ pub mod ancestors {
     pub struct State {
         next: VecDeque<ObjectId>,
         buf: Vec<u8>,
-        seen: BTreeSet<ObjectId>,
+        seen: hash_hasher::HashedSet<ObjectId>,
         parents_with_date: Vec<(ObjectId, u32)>,
         parents_buf: Vec<u8>,
     }