Skip to content

Commit

Permalink
[transport] File implementation doesn't need to inherit git::Connecti…
Browse files Browse the repository at this point in the history
…on's…

…way of dealing with supported versions, but can support all. This is
because we run locally and control a git process which we assume
would hurt the caller if it was malicious.

I mean, it's nothing that's done on the server so being less
paranoid should be fine.
  • Loading branch information
Byron committed Jun 26, 2021
1 parent 812aa3b commit 951b1e2
Showing 1 changed file with 0 additions and 7 deletions.
7 changes: 0 additions & 7 deletions git-transport/src/client/blocking_io/file.rs
Original file line number Diff line number Diff line change
Expand Up @@ -104,13 +104,6 @@ impl client::TransportWithoutIO for SpawnProcessOnDemand {
self.url.to_string()
}

fn supported_protocol_versions(&self) -> &[Protocol] {
self.connection
.as_ref()
.expect("this is called after the handshake")
.supported_protocol_versions()
}

fn is_stateful(&self) -> bool {
true
}
Expand Down

0 comments on commit 951b1e2

Please sign in to comment.