refactor (#301)

Byron · Apr 7, 2022 · dbe7305 · dbe7305
1 parent 8a54341
commit dbe7305
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/git-glob/src/parse.rs b/git-glob/src/parse.rs
@@ -3,6 +3,8 @@ use crate::pattern::Mode;
 use bstr::{BString, ByteSlice};
 
 #[inline]
+/// A sloppy parser that performs only the most basic checks, providing additional information
+/// using `pattern::Mode` flags.
 pub fn parse_line(mut line: &[u8]) -> Option<(BString, pattern::Mode)> {
     let mut mode = Mode::empty();
     if line.is_empty() {
@@ -28,12 +30,14 @@ pub fn parse_line(mut line: &[u8]) -> Option<(BString, pattern::Mode)> {
     if !line.contains(&b'/') {
         mode |= Mode::NO_SUB_DIR;
     }
-    if line.first() == Some(&b'*') && line[1..].find_byteset(br"*?[\").is_none() {
+    if line.first() == Some(&b'*') && line[1..].find_byteset(GLOB_CHARACTERS).is_none() {
         mode |= Mode::ENDS_WITH;
     }
     Some((line, mode))
 }
 
+const GLOB_CHARACTERS: &[u8] = br"*?[\";
+
 /// We always copy just because that's ultimately needed anyway, not because we always have to.
 fn truncate_non_escaped_trailing_spaces(buf: &[u8]) -> BString {
     match buf.rfind_not_byteset(br"\ ") {

diff --git a/git-glob/tests/attributes.rs → git-glob/tests/glob.rs b/git-glob/tests/attributes.rs → git-glob/tests/glob.rs