fix: Assure git@github.com/user/repo urls transform into https urls…

… correctly. (#512)

cargo-smart-release/src/changelog/mod.rs

@@ -6,6 +6,8 @@ pub mod init;
 mod merge;
 mod parse;
 pub mod section;
+#[cfg(test)]
+mod tests;
 pub mod write;
 
 pub const DEFAULT_HEADING_LEVEL: usize = 2;

cargo-smart-release/src/changelog/tests.rs

@@ -0,0 +1,22 @@
+mod repository_url {
+    use crate::changelog::write::RepositoryUrl;
+    use git_repository as git;
+
+    #[test]
+    fn github_https_url() {
+        for input in [
+            "https://github.com/byron/gitoxide",
+            "https://github.com/byron/gitoxide.git",
+            "git://github.com/byron/gitoxide",
+            "git://github.com/byron/gitoxide.git",
+            "git@github.com:byron/gitoxide.git",
+            "git@github.com:byron/gitoxide",
+        ] {
+            let url = RepositoryUrl::from(git::url::parse(input.into()).unwrap());
+            assert_eq!(
+                url.github_https().expect("possible"),
+                "https://github.com/byron/gitoxide"
+            )
+        }
+    }
+}

cargo-smart-release/src/changelog/write.rs

@@ -67,8 +67,9 @@ impl RepositoryUrl {
                 Scheme::Ssh => self
                     .inner
                     .user()
-                    .map(|user| format!("https://github.com{}/{}", user, self.cleaned_path())),
-                Scheme::Radicle | Scheme::File => None,
+                    .filter(|user| *user == "git")
+                    .map(|_git| format!("https://github.com{}", self.cleaned_path())),
+                _ => None,
             },
             None | Some(_) => None,
         }