improvements for Cargo #1323
Merged
improvements for Cargo #1323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… anymore. It does this by ignoring exclude patterns, preferring false-positives that way.
Byron
force-pushed
the
improvements-for-cargo
branch
from
dbf3be5
to
0386871
Compare
…tions in `.gitignore`. Initially, symlinks appear like symlinks thanks to `lstat`, but to do exclude handling correctly these need another `stat` call. However, this is also not done in Git, but done in `libgit2` only, so a toggle was added to act like Git by default, but allow obtaining the same behaviour as git2 for compatibility.
The mode can't be an enum as it would degenerate information, possibly, which is something we really have to avoid. If an enum is desired one day, have a `.kind()` method that creates an enum from the bitflag.
Now symlinked repositories can be traversed as well.
… flag. That way, it can be much more responsive to interruption.
Byron
force-pushed
the
improvements-for-cargo
branch
from
8229c15
to
bc30683
Compare
That way, more copying happens but the usability increases tremendously as well. It's breaking as public types moved from `repository::dirwalk` to `dirwalk`, dissolving `repository::dirwalk` entirely.
Byron
force-pushed
the
improvements-for-cargo
branch
from
bc30683
to
eff82eb
Compare
That way this won't fail, but *just* silently degenerates information. The idea is that during FSCK, objects should be decoded and then re-encoded to see if they are still the same. If not, this means some leniency kicked in. Maybe for FSCK, there would also have to be a refactor so there is a lenient and strict parsing mode. One problem at a time.
Instead, default to UTC just like Git.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improvements to support rust-lang/cargo#13592 .
Tasks
gix-dirwithgit2compatible symlink handling (deviates from git)