Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dep reqwest from gix #1329

Merged
merged 2 commits into from Mar 24, 2024
Merged

Remove dep reqwest from gix #1329

merged 2 commits into from Mar 24, 2024

Conversation

NobodyXu
Copy link
Contributor

Instead forward reqwest feature defined in gix-transport

Instead forward reqwest feature defined in gix-transport

Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
…l` in `gix`. (Byron#1328)

This removes the `curl` dependency just for configuring it, and removes
a hazard which became evident with reqwest.
Copy link
Owner

@Byron Byron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, both for suggesting this change and for implementing it.

I have added the curl-forwarding (just one feature, after all), and will merge once CI is green.

gix-transport/Cargo.toml Show resolved Hide resolved
@Byron Byron merged commit 9e9c653 into Byron:main Mar 24, 2024
18 checks passed
@NobodyXu NobodyXu deleted the patch-1 branch March 24, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants