attributes for worktree-cache #818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Byron
force-pushed
the
attributes-cache
branch
3 times, most recently
from
a252ed8
to
9ce5fb0
Compare
This version works without a `search::pattern::List`.
It's useful to have to avoid certain conversions to happen otherwise.
…ly to git. Previously directory excludes like `dir/` could (possibly) yield different results compared to git. This is an opportunitstic change as it wasn't possible to trigger the wanted behaviour in a test related to directory-specific matching. It did trigger, however, when matching normal patterns which indicated there was indeed a bug.
Also, improve method documentation.
Otherwise it's not possible to keep allocations for matches, while also adjusting pattern lists due to stack changes. On the bright side, this adds some more deduplication to the implementation, at the cost of dealing with some hashmaps that are updated when matching.
44 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make attribute access possible with the attribute cache.
Tasks
path/excludes)