Broken dependency resolution on non-Linux unixes

[mqudsi]

In Cargo.toml, chrono is declared as a dependency only under Linux:

trash-rs/Cargo.toml

Lines 36 to 37 in 3c566ef

	[target.'cfg(target_os = "linux")'.dependencies]
	chrono = "0.4.9"

But it is used in the Freedesktop backend without a Linux-only precondition:

trash-rs/src/freedesktop.rs

Line 18 in 3c566ef

use chrono::{NaiveDateTime, TimeZone};

And the Freedesktop backend is used for any non-macOS unix target:

trash-rs/src/lib.rs

Lines 33 to 35 in 3c566ef

	#[cfg(all(unix, not(target_os = "macos"), not(target_os = "ios"), not(target_os = "android")))]
	#[path = "freedesktop.rs"]
	mod platform;

This causes the build to fail when compiled on a non-Linux unix-ish platform like FreeBSD.

The conditional dependency logic in Cargo.toml needs to match your actual use.

[ArturKovacs]

Feel free to ping me in January if I don't get back until then, because I would be willing to fix this, but not in the coming days.

[Byron]

Thanks very much for reporting, and thanks @ArturKovacs for offering help, it's all very much appreciated.

To get a little more acquainted with the code-base I took a stab at it myself and released a fix.

Now the directives match so I'd hope this also fixes the related issue in dua-cli.

[ArturKovacs]

Thank you for taking good care of this repo @Byron ❤️

[mqudsi]

Thanks for the quick fix and I'm glad I could help. I was originally inclined to reported this as a dua bug because I use trash-rs in my own crates (thanks @ArturKovacs!) and haven't had issues compiling on FreeBSD but I just checked and it's because I opted into using trash 1.3 because of the guidance that was in the README at the time (details of which I cannot precisely recall at the moment).

Sorry to report that build still fails on non-Linux because of a different issue (unsafe use of Linux-only getmntent). There's an alternative way available on the BSDs (and macOS) but it means the code in freedesktop.org will no longer be free of conditional compilation.

[Byron]

Step by step. If you could post the details here maybe a fix can be created from that.

It might also be useful to try and run CI on FreeBSD, which doesn't seem to be straightforward yet.

So I guess we have to go step by step here, maybe it's easiest if @mqudsi would submit a PR that is proven to work.

[wezm]

Sorry to report that build still fails on non-Linux because of a different issue (unsafe use of Linux-only getmntent).

Just ran into this issue on FreeBSD too.

It might also be useful to try and run CI on FreeBSD, which doesn't seem to be straightforward yet.

The easiest way to do CI for FreeBSD is with Cirrus CI. It's free for open source