draft: Check trash path #88
Conversation
There was a problem hiding this comment.
Thanks a lot for contributing, having such a check seems very reasonable.
Why would MacOS not have the example? The commit message didn't tell.
Further it seems that this is only implemented for FreeDesktop, and think this should be implement for all platforms. Once a test is available, CI can be used to validate the implementation as it's fine to try to delete the trash folder on CI for sure.
|
i added freedesktop support because i'm on a linux device and don't have a macos environment to test in. I'll look into it but i can't properly test it. |
Once there is an integration test that tries to delete the trash directory, CI will test it for you. By extension, the And for this feature to go forward, a test will be needed. Thanks for your understanding. |
| if topdir == home_topdir { | ||
| if path.starts_with(home_trash.as_path()) { | ||
| return Err(Error::TargetedTrash); | ||
| } |
There was a problem hiding this comment.
Should no action be performed in this case?
Issue
The current implementation allows the removal of a trash folder with trash-rs
Fix
This seems rather weird so i added a check for it.
Note
I also added an example that simply passes all args to delete_all. I made it anyway so might as well push it.
This is marked as a draft because I'm not sure whether my code meets your quality.