Unbreak build on DragonFly #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DragonFly has `getmntinfo` for `statfs` and `getmntvinfo` for `statvfs`. Use `statfs` variant for compatibility with FreeBSD and OpenBSD. error[E0425]: cannot find function `get_mount_points` in this scope --> czkawka-6.0.0/cargo-crates/trash-3.0.2/src/freedesktop.rs:31:28 | 31 | let mount_points = get_mount_points()?; | ^^^^^^^^^^^^^^^^ not found in this scope error[E0425]: cannot find function `get_mount_points` in this scope --> czkawka-6.0.0/cargo-crates/trash-3.0.2/src/freedesktop.rs:80:24 | 80 | let mount_points = get_mount_points()?; | ^^^^^^^^^^^^^^^^ not found in this scope
|
Thanks a lot for your help! |
|
A new release is available: https://github.com/Byron/trash-rs/releases/tag/v3.1.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found downstream via czkawka and nushell. This is a blind fix as I don't use DragonFly but one can set up CI via dragonflybsd-vm.
DragonFly forked from FreeBSD ~20 years ago, so getmntinfo(3) API is the same but the implementation lacks recent changes like freebsd/freebsd-src@5a28df2e1353 and freebsd/freebsd-src@34ed0c63c878. DragonFly unlike FreeBSD also has getmntvinfo(3) which uses
statvfssimilar to NetBSD getmntinfo(3) but NetBSD lacks getmntvinfo(3) (thusstatvfs-only).For simplicity let's use FreeBSD codepath.