Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Extra Test Case For Merger #7

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zicklag
Copy link

@zicklag zicklag commented Feb 25, 2021

Related to #6, it appears that even after the recent changes that this test still fails.

Also, it's worth noting that I decided to change gears on the way that I'm handling my original use-case, so I won't necessarily be using this anymore. So not super time critical on fixes or anything. 😉

Also, I just submitted a PR for the test so it would be easy to try out, but you don't have to merge it or anything.

@Byron
Copy link
Owner

Byron commented Feb 28, 2021

Thanks a lot! I will definitely give the fix a shot, how hard can it be 😅.

Edit: I took a look and believe this is an issue with the 'value::set` implementation as it fails to set the value like its supposed to. It appears to be a bit too hardcoded to objects in the top-level, and I hope that there is a simple fix.

@mitermayer
Copy link

Is this library still maintained ?

@Byron
Copy link
Owner

Byron commented Mar 24, 2023

Yes, it is. But for fixes I'd hope for contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants