Fixed nasty bug which *could* cause invalid XML output.

Bystroushaak · Feb 16, 2015 · 26a8a7b · 26a8a7b
1 parent 98221ac
commit 26a8a7b
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/CHANGES.rst b/CHANGES.rst
@@ -1,6 +1,10 @@
 Changelog
 =========
 
+2.0.9
+-----
+    - Fixed nasty bug which *could* cause invalid XML output.
+
 2.0.8
 -----
     - Removed _repair_tags() - it wasn't really necessary.

diff --git a/src/dhtmlparser/htmlelement.py b/src/dhtmlparser/htmlelement.py
@@ -884,12 +884,14 @@ def isAlmostEqual(self, tag_name, params=None, fn=None,
         if fn and not fn(self):
             return False
 
+        # compare case sensitive?
+        comparator = self.__tagname  # we need to make self.__tagname lower
         if not case_sensitive and tag_name:
-            self.__tagname = self.__tagname.lower()
             tag_name = tag_name.lower()
+            comparator = comparator.lower()
 
         # compare tagname
-        if tag_name and tag_name != self.__tagname:
+        if tag_name and tag_name != comparator:
             return False
 
         # None params = don't use parameters to compare equality