Fix import collision error in test file #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's happen when run fetch library with `go get` subcommand ``` $ go test -v ./... cpp_compliance_test.go:9:2: case-insensitive import collision: "github.com/bytearena/box2d" and "github.com/ByteArena/box2d" FAIL github.com/ByteArena/box2d [setup failed] ``` because github username use `ByteArena` not `bytearena`
xtuc
approved these changes
Oct 20, 2017
There was a problem hiding this comment.
Thanks for your PR.
I agree, it's better to be consistent with the repo's name. Even if it worked somehow before on Travis and locally. Go is inconsistent or too permissions with the case.
@netgusto make sure you use the capitalized version locally.
fe3dback
pushed a commit
to fe3dback/box2d
that referenced
this pull request
Aug 30, 2020
Fix import collision error in test file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's happen when run fetch library with
go getsubcommandbecause github username use
ByteArenanotbytearena