Formatter #210
Merged
Formatter #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ByteHamster
requested changes
Feb 8, 2017
| * Test inputs that are not percentages | ||
| */ | ||
| @Test(expected = InvalidPercentageException.class) | ||
| public void testPercenteageFormat() { |
| try { | ||
| result = Integer.parseInt(port); | ||
| } catch (NumberFormatException e) { | ||
| throw new InvalidPortException(port, "contains non-digits"); |
There was a problem hiding this comment.
Schöner wäre ein Regex. So hat man halt exceptions im normalen Ablauf
| @@ -3,31 +3,80 @@ | |||
| /** | |||
| * This class provides static methods to check input formats. | |||
| * @param tried The value that was tried to parse | ||
| * @param reason The reason for the failture | ||
| * | ||
| * @param reason The reason for the failure |
| /** | ||
| * JUnit test class for FormatChecker.java | ||
| * @author Maximilian Schwarzmann | ||
| * |
|
|
||
| input = "20b10"; | ||
| result = FormatChecker.checkPort(input); | ||
| assertEquals(20000, result); |
There was a problem hiding this comment.
Das Assert brauchst du nicht (wenn doch, bitte Zahl anpassen)
| * Test negative percentage | ||
| */ | ||
| @Test(expected = InvalidPercentageException.class) | ||
| public void testPercenteageRange() { |
| * Test valid port | ||
| */ | ||
| @Test | ||
| public void testHostPort() { |
There was a problem hiding this comment.
Port? Da wird ein Hostname getestet
| input = "&/(&"; | ||
| FormatChecker.checkHost(input); | ||
| } | ||
| } |
| if (host == null) { | ||
| throw new InvalidHostException(host, "is null"); | ||
| } | ||
| String hostnamePattern = "[0-9a-zA-Z\\-_.]+"; |
There was a problem hiding this comment.
Musst mal schauen, ob man den Punkt auch escapen muss
|
|
… and fixed checkstyle violations
ByteHamster
approved these changes
Feb 10, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.