This repository has been archived by the owner on Dec 20, 2023. It is now read-only.
production like firewall and memory management are disabled by default on xenial #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielnoom
reviewed
Apr 21, 2017
| # ufw is disabled by default with an upstart override in the boxfile image because sometimes | ||
| # the firewall gets in the way when mounting the directories with specific synced folder fs types | ||
| # ufw is disabled by default in the boxfile image because sometimes the firewall gets | ||
| # in the way when mounting the directories with specific synced folder fs types | ||
| if $firewall_enabled; then |
There was a problem hiding this comment.
Should it not be possible to disable the firewall again by using this variable?
There was a problem hiding this comment.
yeah but that was never scripted for precise either, and that's only for the use case when people manually run vagrant provision again on an already existing instance after changing the firewall setting in the local.yml, and I think this script isn't completely idempotent in other places as well. I'd rather rewrite all this post-provisioning stuff in ansible some day instead of crufting all this stuff into this bash script
danielnoom
approved these changes
Apr 21, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
these will now be disabled by default in the xenial image as well. this can be convenient for when using the hypernode-vagrant as a build environment on a larger host than what would be possible in the default production environment (we compile PHP in an LXC hypernode-vagrant on a machine with many cores + a lot of ram, stuff like that should never be oomkilled). disabling the firewall by default will decrease the probability of clashing with the nfs network connections if that fs type is enabled.