This repository has been archived by the owner on Dec 20, 2023. It is now read-only.
fix test site permissions #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
currently if `magento_version` is `2`, the test site permissions will be wrong because the chown doesn't resolve the symlink. this causes the hypernode-importer not to overwrite the index.php file that is placed by default because it would be owned by root:root. before: ``` root@beb7b8-projects-magweb-vgr /data/web/public # ls -strlah total 149K 512 drwxrwxr-x 3 app app 3 Sep 5 2016 .. 512 -rw-rw-r-- 1 app app 12 Nov 14 2016 .gitignore 29K -rw-r--r-- 1 root root 25K Jun 22 15:35 style.css 4.5K -rw-r--r-- 1 root root 757 Jun 22 15:35 opensans.css 53K -rw-r--r-- 1 root root 95K Jun 22 15:35 jquery.min.js 8.5K -rw-r--r-- 1 root root 8.0K Jun 22 15:35 index.php 13K -rw-r--r-- 1 root root 29K Jun 22 15:35 bootstrap.min.js 33K -rw-r--r-- 1 root root 98K Jun 22 15:35 bootstrap.min.css 8.5K drwxrwxr-x 2 app app 9 Jun 22 15:35 . ``` after: ``` root@beb7b8-projects-magweb-vgr /data/web/public # ls -stlrah total 149K 512 drwxrwxr-x 3 app app 3 Sep 5 2016 .. 512 -rw-rw-r-- 1 app app 12 Nov 14 2016 .gitignore 29K -rw-r--r-- 1 app app 25K Jun 22 15:35 style.css 4.5K -rw-r--r-- 1 app app 757 Jun 22 15:35 opensans.css 53K -rw-r--r-- 1 app app 95K Jun 22 15:35 jquery.min.js 8.5K -rw-r--r-- 1 app app 8.0K Jun 22 15:35 index.php 13K -rw-r--r-- 1 app app 29K Jun 22 15:35 bootstrap.min.js 33K -rw-r--r-- 1 app app 98K Jun 22 15:35 bootstrap.min.css 8.5K drwxrwxr-x 2 app app 9 Jun 22 15:35 . ```
vdloo
force-pushed
the
fix-test-site-permissions
branch
from
2ca60ab
to
98581cb
Compare
|
caused the importer to fail copying the index.php in case magento 2 was selected |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
currently if
magento_versionis2, the test site permissions will bewrong because the chown doesn't resolve the symlink. this causes the
hypernode-importer not to overwrite the index.php file that is placed by
default because it would be owned by root:root.
before:
after: